allows more types with the Pointable interface#5
Merged
Conversation
Signed-off-by: Gord Allott <gord@axiom.co>
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 1 1
Lines 182 182
=======================================
Hits 142 142
Misses 24 24
Partials 16 16
Continue to review full report at Codecov.
|
casualjim
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the internal json structure allows for multiple objects at a node, such as
[ {"Foo": "hello"}, {"Bar": "world"}, ]which might be represented in go as
with a JSON unmarshaller that is intelligent enough to allocate the right thing into the right Foo/Bar type.
In this case, it would be prefered for a jsonpointer reference to
/0to return a*Fooobject and not a*Nodeobject. this PR makes this possible by allowing the JSONLookup interface to work with non-struct types