Skip to content

Fix ExtendedResponse parsing#575

Merged
cpuschma merged 1 commit intogo-ldap:masterfrom
giggsoff:fix-ExtendedResponse
Feb 5, 2026
Merged

Fix ExtendedResponse parsing#575
cpuschma merged 1 commit intogo-ldap:masterfrom
giggsoff:fix-ExtendedResponse

Conversation

@giggsoff
Copy link
Contributor

@giggsoff giggsoff commented Feb 2, 2026

According to rfc4511 responseName field in ExtendedResponse is OPTIONAL.

I hit the problem with number of fields parsing 2.16.840.1.113730.3.8.10.5 response where FreeIPA returns only Controls.

According to rfc4511 responseName field in ExtendedResponse is OPTIONAL. I hit the problem with parsing 2.16.840.1.113730.3.8.10.5 response without the fix.
@cpuschma cpuschma self-assigned this Feb 2, 2026
@cpuschma cpuschma added bug go Pull requests that update go code labels Feb 2, 2026
Copy link
Member

@cpuschma cpuschma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will create a follow-up PR to tidy things up. I noticed another oversight unfortunately + I will get rid of the implicit usage of the Extended request name in the response. This is not compliant to the RFC.

Thank you for your PR!

@cpuschma cpuschma merged commit dbef7be into go-ldap:master Feb 5, 2026
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants