use ldap boolean for dirsync control.criticality#555
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Apr 14, 2025
Merged
use ldap boolean for dirsync control.criticality#555cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma merged 2 commits intogo-ldap:masterfrom
Conversation
cpuschma
approved these changes
Apr 14, 2025
Member
cpuschma
left a comment
There was a problem hiding this comment.
@borislavfra LGTM! Thank you for pointing this out and your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LDAP, boolean has stricter encoding rules than in BER. Need to use NewLDAPBoolean so that the value is FF.
https://docs.ldap.com/specs/rfc4511.txt section 5.1