Revert #499: Mark public Start function as deprecated#508
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Apr 12, 2024
Merged
Revert #499: Mark public Start function as deprecated#508cpuschma merged 2 commits intogo-ldap:masterfrom
cpuschma merged 2 commits intogo-ldap:masterfrom
Conversation
…le instability when called (go-ldap#499)" This reverts commit f09ee91.
|
Thanks @cpuschma! When will this be released? I have some codebases now failing to build, as the linter does not like the use of deprecated functions. For the record, our usecase for this is full control over TLS in a piece of code that's part of our TLS certificate expiration checker: |
Member
Author
|
@seveas I still wanted to fix #506 and fix it in the same new release, but I'm not making any progress so far, but have been able to recreate the problem so far. @johnweldon Is it OK for you if I publish a release for the withdrawn commit or do you want to postpone it? |
Member
|
Go ahead and publish a release. Thanks @cpuschma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the prematurely deprecation of the
Startfunction, because some requirements cannot be implemented via the DialOpts (see #507). This PR reverts this, but adds a warning because of the original intention (see #356)