Skip to content

Update dependent packages:#462

Merged
cpuschma merged 6 commits intogo-ldap:masterfrom
iredmail:master
Sep 7, 2023
Merged

Update dependent packages:#462
cpuschma merged 6 commits intogo-ldap:masterfrom
iredmail:master

Conversation

@iredmail
Copy link
Contributor

@iredmail iredmail commented Sep 2, 2023 •
edited
Loading

  • github.com/google/uuid v1.3.1
  • golang.org/x/crypto v0.12.0

@iredmail
Update dependent packages:
fc3f27a 
github.com/google/uuid v1.3.1
github.com/stretchr/testify v1.8.4
golang.org/x/crypto v0.12.0
@iredmail
Keep github.com/stretchr/testify v1.8.0 due to old Go version.
9ef33a0
cpuschma
cpuschma requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@cpuschma cpuschma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. May you mirror the changes to the root directories go.mod and go.sum as well?

Additionally, I just checked and it seems, due to Go 1.21.0, that golang.org/x/crypto has been updated to v0.13.0. May you please run go get -u ./... again?

@iredmail
Copy link
Contributor Author

iredmail commented Sep 6, 2023 •
edited
Loading

According to current v3/go.mod, it requires Go 1.14, do we set it to 1.21.0 or stick to 1.14?
testify package has new version too, but it requires newer Go release.

@cpuschma
Copy link
Member

cpuschma commented Sep 6, 2023 •
edited
Loading

We stick with Go 1.14 unless it's necessary to drop support for it. In both cases this should be addressed in a separate PR

@iredmail
Copy link
Contributor Author

iredmail commented Sep 6, 2023

hi @cpuschma,

Bumped crypto to v0.13.0, please help review and hopefully merge it. :)

@cpuschma
Copy link
Member

cpuschma commented Sep 6, 2023

Thank you. Can you update the deps for the root directories go.mod as well? Then we can merge it

@iredmail
Copy link
Contributor Author

iredmail commented Sep 7, 2023

@cpuschma Done. :)

@cpuschma cpuschma merged commit 07d2e09 into go-ldap:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuschma cpuschma cpuschma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iredmail @cpuschma