ControlSyncRequest Encode: cookie optionality #459
Merged
cpuschma merged 2 commits intogo-ldap:masterfrom Aug 17, 2023
Merged
Conversation
In SyncRequest cookie is optional, so do not add cookie if empty
ControlSyncRequest Encode: cookie optionality
Contributor
Author
|
@t2y FYI |
Contributor
|
According to https://www.rfc-editor.org/rfc/rfc4533.html#section-2.2 , a cookie is optional. You are right. It works that I send nil cookie as I wonder how we handle reloadHint when we don't send a cookie.
or @cpuschma What do you think about proper implementation? |
Contributor
|
@zeslava Thank you for notifying me. I am new to LDAP protocol. I want to think together about which implementation is better. |
Member
|
Agreed, we should stick to the LDAP RFCs and not derivate whereever possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SyncRequest cookie is optional, so do not add cookie if empty