fix: return errors upon panics or receiving unexpected responses#433
Merged
cpuschma merged 3 commits intogo-ldap:masterfrom May 5, 2023
cpuschma:fix_logger
Merged
fix: return errors upon panics or receiving unexpected responses#433cpuschma merged 3 commits intogo-ldap:masterfrom cpuschma:fix_logger
cpuschma merged 3 commits intogo-ldap:masterfrom
cpuschma:fix_logger
Conversation
This replaces the package-wide logger, used in places like processMessages and reader, and returns instead an error. For backwards compatibility, errors returned from goroutine functions are stored in `Conn.err` and can get retrieved through `Conn.GetLastError`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the package-wide logger, used in places like processMessages and reader, and returns an error instead. For backwards compatibility, errors returned from goroutine functions are stored in
Conn.errand can get retrieved throughConn.GetLastError.