Fix deadlocks caused by invalid connection state#432
Merged
cpuschma merged 6 commits intogo-ldap:masterfrom Apr 30, 2023
cholland1989:invalid-state-deadlock
Merged
Fix deadlocks caused by invalid connection state#432cpuschma merged 6 commits intogo-ldap:masterfrom cholland1989:invalid-state-deadlock
cpuschma merged 6 commits intogo-ldap:masterfrom
cholland1989:invalid-state-deadlock
Conversation
added 6 commits
April 29, 2023 16:07
cpuschma
approved these changes
Apr 30, 2023
Member
cpuschma
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your PR ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using this library as part of a network probe, where we attempt to make an unauthenticated bind and gather some basic information about a host that appears to be listening on the standard LDAP ports. We found that in some rare cases, the connection may be killed out-of-band or black holed by an intermediary firewall.
In these cases, we identified a couple of deadlocks in the
v3.Conn.Closeandv3.messageContext.sendResponsemethods:This PR fixes these deadlock conditions by applying the configured timeout in both cases.