implement server side sorting controls (rfc2891)#414
Merged
cpuschma merged 3 commits intogo-ldap:masterfrom Feb 26, 2023
Merged
implement server side sorting controls (rfc2891)#414cpuschma merged 3 commits intogo-ldap:masterfrom
cpuschma merged 3 commits intogo-ldap:masterfrom
Conversation
cpuschma
reviewed
Feb 8, 2023
Member
cpuschma
left a comment
There was a problem hiding this comment.
LGTM so far! Very good first PR, thank you 👍 Can you please look into the comments I left?
I'll run some tests as described regarding the AttributeType field in the ControlServerSideSortingResult struct
Contributor
Author
|
Hey, |
Contributor
Author
|
I've implement the missing decoding function, add a little test to validate my function, add a comment to the valid function and add the type to the maps as you requested ! :p |
…equest, add server side sorting type to ControlMap
228291a to
3b0317d
Compare
cpuschma
approved these changes
Feb 26, 2023
Member
|
Thank you for your PR! ❤️ |
|
Any examples of usage? Crashes with panic for me when I search with a sort control |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I open a PR to implements server side sorting some months ago (#358) and close it for actually no reason :(
I change some variables names which is not clear while reading my old PR. Don't hesitate to tell me if something is wrong in the code I'll fix it :p