conn: Ensure 64-bit alignment for atomics on 32-bit platforms#199
Merged
johnweldon merged 1 commit intogo-ldap:masterfrom Dec 1, 2018
Psychotropos:bugfix/atomic-alignment
Merged
conn: Ensure 64-bit alignment for atomics on 32-bit platforms#199johnweldon merged 1 commit intogo-ldap:masterfrom Psychotropos:bugfix/atomic-alignment
johnweldon merged 1 commit intogo-ldap:masterfrom
Psychotropos:bugfix/atomic-alignment
Conversation
Member
|
Thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As it currently stands, there is no guarantee that the requestTimeout variable on a Conn structure is going to be aligned to a 64-bit boundary. As golang/go#599 is not fixed as of yet, it is still the caller's responsibility to ensure that is the case.
This pull request should resolve issues #185 and #195 by moving requestTimeout to the very beginning of the structure. The alternative would be to manually pad the structure, and that offers no guarantees of no regression occurring due to the length of the structure changing in future versions.