Merge upstream square/go-jose:v2 into go-jose/go-jose:v2 while preserving existing history#28
Merged
jsha merged 24 commits intogo-jose:v2from Jan 23, 2023
pgporada:v2
Merged
Merge upstream square/go-jose:v2 into go-jose/go-jose:v2 while preserving existing history#28jsha merged 24 commits intogo-jose:v2from pgporada:v2
jsha merged 24 commits intogo-jose:v2from
pgporada:v2
Conversation
The JWT NumericDate type is a Unix/POSIX timestamp, which ignores leap seconds as far as I know. This said "including leap seconds" which was confusing. Use "ignoring leap seconds" which is direct from the RFC: RFC7519 Section 2 states: https://tools.ietf.org/html/rfc7519#section-2 A JSON numeric value representing the number of seconds from 1970-01-01T00:00:00Z UTC until the specified UTC date/time, ignoring leap seconds. This is equivalent to the IEEE Std 1003.1, 2013 Edition [POSIX.1] definition "Seconds Since the Epoch", in which each day is accounted for by exactly 86400 seconds, other than that non-integer values can be represented.
Cherry pick of PR #306
Cherry pick of PR #309
Update .travis.yml
Regenerate X.509 cert with SAN extension (v2)
Typo fixes for doc_test.go, cbc_hmac.go and other places
Mnr typos in opaque.go
Unmarshal JSON integer numbers into `interface{}` as `int64`
Add support for non-pointer jose.JSONWebKeySet
fix: add ExtraHeaders from options object to multi encrypter
jsha
approved these changes
Jan 23, 2023
Collaborator
Author
|
We noticed something odd with square/go-jose after this was merged.
You'll see this missing commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-jose/go-jose:v2was forked fromsquare/go-jose:v2at commit3a5ee095dcb5030a9de84fb92c222ac652fff176Since that commit,square/go-jose:v2andgo-jose/go-jose:v2diverged and had development in each respectivev2branch. Now that Let's Encrypt are the stewards of this repository, we want to merge the divergent histories together back into one cohesive history. Doing this will allow current users ofsquare/go-jose:v2using tagged versionsv2.5.1orv2.6.0to switch togo-jose/go-jose:v2and eventually use those same tags once they've been cut. This is nice because as development continues ongo-jose/go-jose:v3,v2users will have one less upgrade to perform in their own modules files.For the pedantic, this could have been accomplished several ways. Here's two such ways:
or