Merged
Conversation
Also fix golang/go#65051 and resolve obvious linting problems.
e274ad6 to
151e3bf
Compare
Contributor
Author
|
@rogpeppe, @mhilton, @tasdomas, @alesstimec, I'd appreciate your reviews, thanks. |
tasdomas
approved these changes
Apr 13, 2024
rogpeppe
approved these changes
Apr 15, 2024
Contributor
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM with a couple of trivial suggestions.
Contributor
Author
|
@rogpeppe, I think we can merge, thanks |
Contributor
Author
|
Hey @rogpeppe, any updates? |
1 similar comment
Contributor
Author
|
Hey @rogpeppe, any updates? |
Contributor
Author
|
Hey @rogpeppe, could you kindly review and merge this PR? Thanks. |
rogpeppe
approved these changes
Jan 20, 2025
Contributor
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM with one minor suggestion, which can be done as a follow-up if desired. Sorry for the ultra-slow review!
| @@ -1,4 +1,5 @@ | |||
| // +build go1.8 | |||
| //go:build go1.19 | |||
Contributor
There was a problem hiding this comment.
This doesn't seem necessary anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix golang/go#65051 and resolve obvious linting problems.