fix: double quoted string literals in migrator#183
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Mar 9, 2024
ncruces:master
Merged
fix: double quoted string literals in migrator#183jinzhu merged 1 commit intogo-gorm:masterfrom ncruces:master
jinzhu merged 1 commit intogo-gorm:masterfrom
ncruces:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Using
%qis not appropriate to quote a string literal in RAW SQL. Double-quoted strings are considered a misfeature of SQLite, and advised to be disabled at compile time. Also,%qproduces the wrong quoting:Hi "GORM"!is quoted as"Hi \"GORM\"!"not"Hi ""GORM""!", as SQLite would expect.Current head fails GORM
TestMigrateWithUniqueIndexAndUniqueif SQLite is configured withSQLITE_DQS=0.User Case Description