Revert "plumbing: format/packfile, prevent large objects from being read into memory completely (#303)"#329
Merged
mcuadros merged 1 commit intogo-git:masterfrom Jun 2, 2021
Merged
Conversation
…ead into memory completely (go-git#303)" This reverts commit 720c192.
Member
|
Thanks, I was about to do it. Don't worry these things happens. |
This was referenced Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 720c192.
It appears that this just doesn't work and is causing major problems.
I think the changes in storage/filesystem/object.go are fine but the delta and OFS changes would need more thought. (Likely changing the readers to always use ReadAt(...) or something shadowing that with a stored offset.
I deeply apologise for breaking workflow - I had thought that the tests were catching this - clearly not.