storage: filesystem, close packfile iterators after use#2027
Merged
Conversation
pjbgf
approved these changes
Apr 27, 2026
pjbgf
left a comment
Member
There was a problem hiding this comment.
@aymanbagabas thanks for working on this. 🙇
This fixes some leaks of file descriptors when iterating over packfiles. The packfile iterators are now closed after use, and the file descriptor is closed if an error occurs while creating the zlib reader. Related: https://github.com/go-git/go-git/actions/runs/24908334127/job/72949435719?pr=1987 Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
ad8f60d to
f8b32a6
Compare
pjbgf
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some leaks of file descriptors when iterating over packfiles. The packfile iterators are now closed after use, and the file descriptor is closed if an error occurs while creating the zlib reader.
Related: https://github.com/go-git/go-git/actions/runs/24908334127/job/72949435719?pr=1987