Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the revive linter to enforce Go code quality standards across the codebase. The changes focus on improving code style, documentation, and naming conventions without altering functionality.
Key changes include:
- Enabling revive linter in golangci configuration
- Adding package and exported item documentation throughout the codebase
- Improving variable naming to avoid shadowing (e.g.,
close→closeBracket,new→newRef) - Marking unused parameters with underscore (
_) convention - Simplifying if-else blocks by removing unnecessary else statements
- Renaming
path_utilpackage topathutilfor consistency - Fixing constant naming conventions (e.g.,
Version_0→Version0,ConfigStorer→Storer)
Reviewed changes
Copilot reviewed 164 out of 164 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yaml | Added revive linter to enabled linters list |
| worktree*.go | Marked unused function parameters with underscore |
| storage/** | Added documentation comments and improved variable naming |
| plumbing/** | Added package docs, improved naming (close→closeBracket, new→newRef) |
| config/** | Renamed ConfigStorer→Storer, improved constant names, added error docs |
| internal/pathutil/ | Renamed from path_util, added package documentation |
| utils/** | Added package and exported function documentation |
| Multiple test files | Renamed close→cancel for context cancellation functions |
| submodule.go | Improved variable naming (new→opts) |
| remote.go | Fixed variable shadowing issues (new→newRef, proxyUrl→proxyURL) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
80bdde5 to
0450e89
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
0450e89 to
4d521a8
Compare
pjbgf
requested changes
Dec 3, 2025
Member
pjbgf
left a comment
There was a problem hiding this comment.
@ferhatelmas just a few nits, otherwise LGTM.
alexandear
approved these changes
Dec 3, 2025
Contributor
Author
|
PTAL. I pushed a separate commit for easier iteration. |
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
3b2cdd0 to
fc79cd7
Compare
pjbgf
approved these changes
Dec 4, 2025
Member
pjbgf
left a comment
There was a problem hiding this comment.
@ferhatelmas thanks for working on this. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1753