*: enable formatters in golangci-lint#1754
Conversation
5c32c8d to
841244b
Compare
There was a problem hiding this comment.
Pull request overview
This PR enables formatters in golangci-lint, applying automated formatting changes across the entire codebase. The changes are purely stylistic and do not alter functionality, focusing on code consistency and adherence to Go best practices.
Key formatting changes applied:
- Reorganized imports with proper grouping (standard library, external, internal)
- Converted octal literals to use the
0oprefix (e.g.,0644→0o644) - Replaced naked returns with explicit return statements
- Replaced
interface{}withany(Go 1.18+ syntax) - Merged function parameter names with identical types
- Fixed indentation in comments and documentation
- Applied
varto:=conversions where appropriate - Improved struct literal and slice formatting
Reviewed changes
Copilot reviewed 251 out of 257 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| worktree*.go | Import reordering, explicit returns, octal literal updates |
| utils/** | Replaced interface{} with any in sync pools and function signatures |
| plumbing/** | Extensive formatting: imports, returns, octal literals, parameter merging |
| storage/** | Import reordering and test file consistency |
| *.go (root) | Import organization and minor formatting adjustments |
All changes are consistent with modern Go formatting conventions and the PR successfully achieves its goal of enabling formatters in golangci-lint without introducing any functional changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
b3f51d3 to
e3d90cf
Compare
fixes go-git#1751 * not enabling goimports because gci covers same functionality. Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
e3d90cf to
196ef80
Compare
|
@pjbgf it's ready to review |
pjbgf
left a comment
There was a problem hiding this comment.
@ferhatelmas thanks for implementing this and getting the project better formatted. 🙇
fixes #1751