@pjbgf tried catching the ModeSocket in calculateHash(...) as here:
b7aa82e

The error I get now is:
Error: to: no equivalent git mode for Srwxr-xr-x

Originating from here:

Lines 67 to 98 in a99446e

    
           // NewFromOSFileMode returns the FileMode used by git to represent 
        
           // the provided file system modes and a nil error on success.  If the 
        
           // file system mode cannot be mapped to any valid git mode (as with 
        
           // sockets or named pipes), it will return Empty and an error. 
        
           // 
        
           // Note that some git modes cannot be generated from os.FileModes, like 
        
           // Deprecated and Submodule; while Empty will be returned, along with an 
        
           // error, only when the method fails. 
        
           func NewFromOSFileMode(m os.FileMode) (FileMode, error) { 
        
           	if m.IsRegular() { 
        
           		if isSetTemporary(m) { 
        
           			return Empty, fmt.Errorf("no equivalent git mode for %s", m) 
        
           		} 
        
           		if isSetCharDevice(m) { 
        
           			return Empty, fmt.Errorf("no equivalent git mode for %s", m) 
        
           		} 
        
           		if isSetUserExecutable(m) { 
        
           			return Executable, nil 
        
           		} 
        
           		return Regular, nil 
        
           	} 
        
           	if m.IsDir() { 
        
           		return Dir, nil 
        
           	} 
        
           	if isSetSymLink(m) { 
        
           		return Symlink, nil 
        
           	} 
        
           	return Empty, fmt.Errorf("no equivalent git mode for %s", m) 
        
           }

Which is basically the next call after retrieving the hash. I somewhat have the feeling the Sockets have to be filtered out earlier since calculateHash()

go-git/utils/merkletrie/filesystem/node.go

Line 142 in b7aa82e

func (n *node) calculateHash(path string, file os.FileInfo) ([]byte, error) {

does need to return a byte slice and the calling newChildNode(...) would also error out or add the child to the children slice.

go-git/utils/merkletrie/filesystem/node.go

Line 117 in b7aa82e

func (n *node) newChildNode(file os.FileInfo) (*node, error) {

	// NewFromOSFileMode returns the FileMode used by git to represent
	// the provided file system modes and a nil error on success. If the
	// file system mode cannot be mapped to any valid git mode (as with
	// sockets or named pipes), it will return Empty and an error.
	//
	// Note that some git modes cannot be generated from os.FileModes, like
	// Deprecated and Submodule; while Empty will be returned, along with an
	// error, only when the method fails.
	func NewFromOSFileMode(m os.FileMode) (FileMode, error) {
	if m.IsRegular() {
	if isSetTemporary(m) {
	return Empty, fmt.Errorf("no equivalent git mode for %s", m)
	}
	if isSetCharDevice(m) {
	return Empty, fmt.Errorf("no equivalent git mode for %s", m)
	}
	if isSetUserExecutable(m) {
	return Executable, nil
	}
	return Regular, nil
	}

	if m.IsDir() {
	return Dir, nil
	}

	if isSetSymLink(m) {
	return Symlink, nil
	}

	return Empty, fmt.Errorf("no equivalent git mode for %s", m)
	}

Ignore .sock files in git.WorkTree #312

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Ignore `.sock` files in `git.WorkTree` #312