Update Config.Client to redis.UniversalClient for Cluster Support (#24)#26
Merged
Conversation
jlordiales
reviewed
Apr 16, 2025
Contributor
Author
|
@VojtechVitek @pkieltyka hello, please help to review this, thanks |
VojtechVitek
approved these changes
Jun 11, 2025
VojtechVitek
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Thank you for your contribution :)
|
@namigaliyev Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
Config.Clientfield inhttprateredis.Configfrom*redis.Clienttoredis.UniversalClientto enable support for Redis cluster mode via*redis.ClusterClient, addressing issue #24.Motivation:
*redis.Clienttype limitshttprateredisto single Redis instances, causing type mismatch errors when using*redis.ClusterClientredis.UniversalClientis a flexible interface supporting both*redis.Client(single instance),*redis.ClusterClient(cluster mode), and*redis.Ring (sharded Redis), making it suitable for broader use cases.Changes:
Config.Clientinconfig.gofrom*redis.Client toredis.UniversalClient.Impact:
httprateredisto work seamlessly with Redis cluster mode, addressing community demand in Allow other go-redis client implementations #24.*redis.Clientusage for single-instance Redis.redis.UniversalClientimplementations.