Optimize throttle middleware by avoiding unnecessary timer creation#1011
Merged
VojtechVitek merged 1 commit intoAug 26, 2025
Merged
Conversation
- Only create time.NewTimer() when actually needed to wait - Reduces allocations from 7 to 4 and memory usage by ~54% - Improves performance by ~50% in high-throughput scenarios
VojtechVitek
approved these changes
Aug 1, 2025
VojtechVitek
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you!
I'll wait few more days before merging to allow more 👀 reviews
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark results:
Before:
After: