runtime/build: Install swig even without python#3874
runtime/build: Install swig even without python#3874doronbehar wants to merge 1 commit intognuradio:maint-3.8from
Conversation
|
3.7 backport: #3875 |
|
Can you be more specific on the failures you are seeing? |
|
Sure, for (3.7) with gr-osmosdr (with the last version of gr-osmosdr that supports 3.7): |
|
It seems to me like the OOT should not be building swig related stuff at all if it is being built with https://github.com/osmocom/gr-osmosdr/blob/gr3.7/CMakeLists.txt#L240 I wonder why its doing swig stuff at all... are you sure this is being passed into the OOT? |
|
There should be no reason for swig if python is not enabled. Seems like this should be fixed on the OOT side |
|
Well if python and swig are available during build of gr-osmosdr, it assumes (righteously I suppose) that GNUradio was built with swig files as well. And, if I don't add python and swig to the build of gr-osmosdr, and I build it with a gnuradio without python support, it builds fine, as expected. Hence it means we should not enable python support for gr-osmosdr when it's built with a gnuradio without python support as well. I'll close this and the other PR as they are not justified indeed. Thanks for the feedback. |
On NixOS, we noticed that if python-support is not enabled, many applications that depend on gnuradio-runtime fail to build. With this patch, swig files are always installed, regardless of whether python-support is enabled.