Skip to content

Conversation

@phychi
Copy link
Contributor

@phychi phychi commented Jul 30, 2025

Added a check to ensure that X1 <= N1 and X2 <= N2 in the ztest2 function. In addition, some spelling mistakes have been fixed.

phychi added 2 commits July 30, 2025 15:54
Added a check to ensure that X1 <= N1 and X2 <= N2 in the ztest2 function.
@phychi phychi changed the title Add input validation for ztest2 sample sizes and some fix typo Add input validation for ztest2 and some fix typo Jul 30, 2025
@pr0m1th3as
Copy link
Member

Thank you for the PR. For future reference, please open different PRs for different types of changes. For example, in this case, you could (should) open a PR for fixing typos in documentation, another for adding input validation in zscore, and a third one for the fix in the classification classes. This makes is easier for me to review your suggested changes, but it makes it easier to request revision for particular changes instead of the entire PR.
A final remark, when adding input validation tests, it is best practice (whenever possible) to query the error message in the unit test so that we are sure that the error is called from the exact part of the code as expected.

@pr0m1th3as pr0m1th3as merged commit e6e0bb2 into gnu-octave:main Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants