Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gnprice/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.55.4
Choose a base ref
...
head repository: gnprice/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: text-experiments-0.55
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Jun 11, 2018

  1. Fix extreme TextInput slowness on Android

    This reverts 5898817 "Implement letterSpacing on Android >= 5.0".
    Testing shows that that commit is the cause of facebook#19126, where in a
    controlled TextInput after some text is first added, then deleted,
    further interaction with the TextInput becomes extremely slow.
    
    Fixes facebook#19126.
    gnprice committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    a8c65a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. [nomerge] Try un-reverting except on TextInput code -- bug returns.

    If we can, we'd like to get the benefit of the original change at
    least on ordinary Text components.  The issue we're fixing seems like
    it can't trigger there, or at least is much less likely to than on
    TextInput.
    
    So, try un-reverting all the changes to files that aren't specifically
    about TextInput.
    
    Unfortunately, this causes the issue to reproduce again.
    gnprice committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    7e67c90 View commit details
    Browse the repository at this point in the history
  2. [nomerge] Try re-reverting setAllowFontScaling -- still repros.

    In order to try to nail down what causes TextInputs to suffer this
    issue even though all the specifically TextInput-related changes from
    the original commit have been reverted, try knocking out one of the
    places where the original commit causes its new code to get called.
    
    The bug still repros, so this isn't enough.
    gnprice committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    3b874da View commit details
    Browse the repository at this point in the history
  3. [nomerge] Try re-reverting build-from-shadow instead -- now works!

    Undo the last commit's experiment, and re-revert instead the other
    spot where the original commit caused its new code to get called:
    inside `buildSpannedFromShadowNode`.
    
    This causes the issue to be fixed again!  So, this hunk is the
    difference between TextInputs getting (painfully) slow and not.
    
    Unfortunately, it also looks to me like it's probably the key entry
    point to the whole change -- so keeping this knocked out has much the
    same effect in practice as just reverting the entire original commit.
    gnprice committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    2f2ceaa View commit details
    Browse the repository at this point in the history
Loading