-[bug 949] #949 its reported in the issue that the save button in la…#970
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Jan 12, 2025
Conversation
…ve button in layout overrides the profile, custom command, working dir. The same does not happen when close button is pressed or pref window is closed. In my observation,I have seem that the profile is overwritten, but custom command and wording dir are updated. The updation of working dir and custom command when editing without save button seems a bit different but I haven't changed that part for now. For sake of consistency I have ensured the updatation of profile (which anyways gets updated from drop down menu) but is over written by save button, happens when save button is pressed.
Member
|
Looks good, sorry about the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its reported in the issue that the save button in layout overrides the profile, custom command, working dir. The same does not happen when close button is pressed or pref window is closed. In my observation,I have seen that the profile is overwritten, but custom command and wording dir are updated.
The updation of working dir and custom command when editing without save button seems a bit different but I haven't changed that part for now.
For sake of consistency I have ensured the updation of profile (which anyways gets updated from drop down menu) but is over written by save button, happens when save button is pressed.