[bug 760] working directory feature is broken#882
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Feb 15, 2024
Merged
Conversation
Contributor
vssdeo
commented
Feb 5, 2024
- as per the bug the layout does not get updated when "Save" button in layout is pressed
- it does get updated if the window is closed by pressing top x close icon.
- on pressing Save, it seems that the prefseditor takes this from current_layout = terminator.describe_layout() and saves it in config
- whereas the current changes are done per key stroke and config is updated
- this patch copies the parameters like directory and command when Save is press and on_layoutrefreshbutton_clicked() is called
- Hence working dir and command are copied when Save is pressed using uuid to match terminals.
- If there is a command registered then the terminal runs the command and exits. so one is not able to see the results.
- as per the bug the layout does not get updated when "Save" button in layout is pressed - it does get updated if the window is closed by pressing top x close icon. - on pressing Save, it seems that the prefseditor takes this from current_layout = terminator.describe_layout() and saves it in config - whereas the current changes are done per key stroke and config is updated - this patch copies the parameters like directory and command when Save is press and on_layoutrefreshbutton_clicked() is called - Hence working dir and command are copied when Save is pressed using uuid to match terminals. - If there is a command registered then the terminal runs the command and exits. so one is not able to see the results.
Member
|
You did it you mad genius! :) This has been a problem for so long it's in the docs that were written before I took over. I'll take another look at it before merging it, but all I have to say is: Wow, good job! |
Contributor
Author
I shall print and frame this :) @mattrose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.