681 Plugin submission mouseless keyboard url open decoupled code#810
Merged
mattrose merged 4 commits intognome-terminator:masterfrom Aug 26, 2023
Conversation
- this branch is further decoupled using the current commit, 681-Plugin-Submission-Plugin-Utility-KeyBinding-Mouseless-Keyboard-URL-Open
…ouseless-Keyboard-URL-Open that were to be decoupled
…ode in a diff issue Plugin Submission + Generic Plugin Utility Functions & KeyBinding Feature: Mouseless / Mousefree / Keyboard URL opening or yanking
Member
|
I think that this needs to pull the other PR in from the other branch. I'll see if I can pull it in |
Contributor
Author
|
You have already merged the dependency, not sure why the ERROR terminatorlib/plugins/mousefree_url_handler.py - ImportError: cannot import name 'KeyBindUtil' from 'terminatorlib.plugin' (/home/runner/work/terminator/terminator/terminatorlib/plugin.py Locally I updated my branch with master and copied the plugin it seems to work, let me check more on this |
Member
|
This branch still doesn't have the merged code in it, so it will always fail the test. You could merge the code from master and then push the merged branch back, that should fix it. |
…sion-Plugin-Utility-KeyBinding-Mouseless-Keyboard-URL-Open
Contributor
Author
|
ok got it ! |
Member
|
Looks Good! Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #681
Resubmitting plugin for mousefree url handler on terminal with decoupled code and dependencies below that have to be fulfilled.
DEPENDENCIES:
#806
#809