Remove more unused settings and update the docs accordingly#735
Merged
mattrose merged 2 commits intognome-terminator:masterfrom Apr 5, 2023
Merged
Conversation
Removed settings: scroll_background, focus_on_close, cycle_term_tab, ignore_hosts.
The color scheme in use is determined by checking the 'foreground_color' and 'background_color' settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR, I removed some global settings. This time, these are profile settings.
Looking at the git history, these settings were once in use, but became unused many years ago.
Removed settings: scroll_background, focus_on_close, cycle_term_tab, ignore_hosts.
There are a few more settings that I'm not totally sure if they are useful or not: term, colorterm and http_proxy. These cannot be accessed from the GUI, and they are used as environment variables.
However, I would say that should be done at the shell level, especially the proxy.
I've left them in there, in case someone is using them somehow.
Edit: removed the color_scheme setting as well.