Better distinguishing of inactive windows from the active one, by changing the background brightness#709
Conversation
Normally, one can only change the background of the foreground for the inactive window. With this change the background of the inactive window will also change it's brightness by 20%.
Vulcalien
left a comment
There was a problem hiding this comment.
It works as intended, great!
It's a feature that should obviously be present.
The only thing to consider is if the default should be 80% (as it is in the PR) or 100% (current behavior).
In preferences.glade some widgets got shuffled by the tool. That might create some conflicts with other PRs.
|
Cool, that it can be introduced! I have changed the default value to 100%. Regarding the |
|
It's been a bit since I touched that code, but how does it work with transparent or image backgrounds? Does it just set the bgcolor to black? Can you try this out? |
|
I gave it a shot with both transparent and image backgrounds and it doesn't seem to work. This is ... not entirely unexpected, and honestly, it's probably fine, as the unfocussed code is going to be re-written at some point in the GTK4 process anyways. I have some ideas on how to fix this, but that way lies madness. |
|
Anyway, that said, I'm fine with this if you are. |
Hello!
I normally don't use title bar, thus differentiation between active and inactive windows, when there is not much in the foreground, is hard for me.
To better explain this, check out this GIF - the problem:
When there is not much data on the terminals, then it's hard to distinguish in which terminal I'm currently writing.
With this PR, one can change the background brightness of the Inactive window:
I have introduced a setting which allows changing the background brightness of the inactive window:
This PR introduces changes to the background color, and the implementation is a simple copy-pasted solution, scrapped from the
inactive_color_offset, which controls the brightness of the font for an inactive window.At this stage, it is a draft, because I have few questions: