Skip to content

Add detachable tabs feature to preferences#698

Merged
mattrose merged 3 commits intognome-terminator:masterfrom
zpalmtree:add-detchable-tabs-preference
Apr 24, 2023
Merged

Add detachable tabs feature to preferences#698
mattrose merged 3 commits intognome-terminator:masterfrom
zpalmtree:add-detchable-tabs-preference

Conversation

@zpalmtree
Copy link
Copy Markdown
Contributor

@zpalmtree zpalmtree commented Dec 29, 2022

Fixes #697.

Not sure why so much markup got changed, guess some new glade version thing.

@Vulcalien Vulcalien added the enhancement New feature or request label Feb 14, 2023
@Vulcalien
Copy link
Copy Markdown
Member

Vulcalien commented Feb 15, 2023

I tested it and it seems to work fine. Thanks for the help!

The initialization code in prefseditor.py is in the wrong function (profile instead of global), but I made a PR to your fork.
Other than that, seems all good!

@zpalmtree
Merge pull request #1 from Vulcalien/origin/add-detchable-tabs-prefer…
ca86d08 
…ence

Detachable tabs: reposition preferences code
@zpalmtree
Copy link
Copy Markdown
Contributor Author

zpalmtree commented Feb 16, 2023

Merged your PR, thanks for the help!

@mattrose
Copy link
Copy Markdown
Member

mattrose commented Mar 1, 2023

I'm probably blind, but I can't see the detachable tabs check box when I pull your code in? Can you put up a screenshot or something to help me?

@zpalmtree
Copy link
Copy Markdown
Contributor Author

zpalmtree commented Mar 1, 2023

I'm probably blind, but I can't see the detachable tabs check box when I pull your code in? Can you put up a screenshot or something to help me?

It should appear here:
image

Perhaps you have an existing terminator instance open? When I was testing out my changes if I had any other terminators open, it would reuse the old code and not reflect any new changes.

nautics889
nautics889 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nautics889 nautics889 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine on for me.

I see a toggle in preferences and it works correctly when i disable/enable one:
Screenshot 2023-04-17 234716

Thank you!

@mattrose
Copy link
Copy Markdown
Member

mattrose commented Apr 24, 2023

all good now, sorry about the wait.

@mattrose mattrose merged commit e0592ea into gnome-terminator:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nautics889 nautics889 nautics889 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable detachable tabs flag

4 participants

@zpalmtree @Vulcalien @mattrose @nautics889