Fix: handle_size treated as cell_width#561
Merged
mattrose merged 2 commits intognome-terminator:masterfrom Dec 26, 2021
Merged
Conversation
Contributor
|
@Vulcalien Thanks a lot for spotting the problem and the fixing it! Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #552 the cell_width setting was introduced.
However, the GUI has a bug that makes the
handle_sizebe considered ascell_width.To reproduce:
I also moved "Cell Height" after "Cell Width", so that we have "width, height" instead of "height, width".