Remove Encoding settings (deprecated)#536
Conversation
|
✔️ Less Code I like it! |
|
How should I go about changing the terminal encoding after the option has been removed? |
One of the biggest influencing factors of my use of the terminal is that it is very convenient to modify the terminal encoding |
I hope to add this feature back to the built-in plugin and set it to be turned off by default. Although most people don't need this feature, it is indispensable. |
|
The reason we removed it was that vte, the terminal GTK component, deprecated it. It would be up to them to add it back, and then we could revert this change as well. It is very unfortunate, but maybe a command like |
Issue #534
All I did was remove code. I don't expect anything breaking, since it doesn't seem to be connected to other code.
List of changes
encoding.pywas entirely deleted.preferences.gladeused to select encoding was removed, along with the signal handlers inprefseditor.pyterminal_popup_menu.py) was removed, along with the signal handler interminal.pyencodingandactive_encodingswere removedI don't know if there is a way to test this, since it's a feature removal. I just opened the menus and no error messages were being printed.