BugFix: terminal won't restart if there is no custom command#500
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Aug 31, 2021
Merged
BugFix: terminal won't restart if there is no custom command#500mattrose merged 1 commit intognome-terminator:masterfrom
mattrose merged 1 commit intognome-terminator:masterfrom
Conversation
Member
|
will pull when checks complete. |
Member
|
Thanks again! :) |
Member
Author
|
You're welcome! This was a quick one. Actually, I found it easily because of the log error you sent. I hadn't noticed this before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem that we discovered in #498, but not the entire issue.
For some reason, something related to debug makes Terminator crash. That might be another bug.
Apparently, the parameter order was messed up, and the
Restart the commandthing would work only when there is a custom command. With this patch it should work fine even if it's not selected.