Skip to content

Set CAN_FOCUS to False for notebook widgets#470

Merged
mattrose merged 1 commit intognome-terminator:masterfrom
marktiro:issue#400-disable-tab-focusing
Jul 23, 2021
Merged

Set CAN_FOCUS to False for notebook widgets#470
mattrose merged 1 commit intognome-terminator:masterfrom
marktiro:issue#400-disable-tab-focusing

Conversation

@marktiro
Copy link
Copy Markdown
Contributor

Resolves #issue400

Apparently, we do not need to subscribe on focus-grub event and put the grab back to the VTE terminal. Adding a setting can_focus=false is enough.

Applying it I am still able to rename the tab by a double click, though just clicking on it does not steal l the focus.

@mattrose
Copy link
Copy Markdown
Member

This looks perfect and I'm sure it works, but I'll just take a look at this and merge this tomorrow (Friday) if work is not too busy. Thanks so much! It's hard to believe a bug that's been open for 4 years has a one-line fix.

@marktiro
Copy link
Copy Markdown
Contributor Author

Well, well. We still need your check in the sense that the commit made in gnome-terminal at https://bug746665.bugzilla-attachments.gnome.org/attachment.cgi?id=300270 clearly states that:

Merely setting TerminalTabLabel:can-focus to FALSE is not enough to
prevent the keyboard focus from entering the tab label.

That's exactly what I did but it works for me. Maybe there was another problem in GTK at the moment that was fixed during these 4 years, and so now we can just use can_focus=False

@mattrose
Copy link
Copy Markdown
Member

Works for me too, merging!

@mattrose mattrose merged commit 27555de into gnome-terminator:master Jul 23, 2021
@mattrose
Copy link
Copy Markdown
Member

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal loses focus versus tab title

2 participants