Bug Fix: 'Clear selection on copy' is always unchecked#443
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Jun 3, 2021
Merged
Bug Fix: 'Clear selection on copy' is always unchecked#443mattrose merged 1 commit intognome-terminator:masterfrom
mattrose merged 1 commit intognome-terminator:masterfrom
Conversation
Member
|
Thanks again for all your help. I'm really busy with other life aspects right now and this really does help, both the project and me mentally. Nothing makes me happier than seeing an unbidden PR that fixes a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkbox for "Clear selection on copy" was always unchecked, because the widget active status was not set.
And the id of the checkbox in preferences.glade was not set.
To Reproduce
Try to check "Clear selection on copy" and then close the preferences menu. When opened again, it's unchecked.