Skip to content

add feat: config to open links with single click#398

Merged
mattrose merged 2 commits intognome-terminator:masterfrom
nojhan:feat/config+link_single_click
Apr 12, 2021
Merged

add feat: config to open links with single click#398
mattrose merged 2 commits intognome-terminator:masterfrom
nojhan:feat/config+link_single_click

Conversation

@nojhan
Copy link
Copy Markdown
Contributor

@nojhan nojhan commented Mar 4, 2021

Instead of Ctrl-left click.

Note: I only have glade 3.22.2 instead of the 3.36.0 used for the previous setup.
I guess that's why there have been some editions in the XML, apart for the new checkbox.
I have absolutely no idea if that's a problem or not… the window works well on my Ubuntu 20.04, at least.

@mattrose
Copy link
Copy Markdown
Member

mattrose commented Mar 6, 2021

This is definitely a feature I've wanted to add for a while! Thank you. I've been really busy but this is at the top of my to-merge list

@mattrose
Copy link
Copy Markdown
Member

mattrose commented Mar 7, 2021

I get this error when trying to check the box

Traceback (most recent call last):
File "/Users/mattrose/Code/terminator/terminatorlib/prefseditor.py", line 1426, in on_link_single_click_toggled
self.config['link_single_click'] = widget.get_active()
NameError: name 'widget' is not defined

@mattrose
Copy link
Copy Markdown
Member

mattrose commented Mar 7, 2021

And it doesn't seem to set the config variable properly. Can you take a look at this again?

@mattrose mattrose closed this Mar 7, 2021
@mattrose mattrose reopened this Mar 7, 2021
@mattrose
Copy link
Copy Markdown
Member

mattrose commented Mar 7, 2021

sorry, clicked wrong button there.

@nojhan
Copy link
Copy Markdown
Contributor Author

nojhan commented Mar 9, 2021

It should be fixed now.

@mattrose
Copy link
Copy Markdown
Member

Looks good, merging

@mattrose mattrose merged commit 9ad1412 into gnome-terminator:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants