Add new vsplit hsplit cmd dbus#390
Merged
mattrose merged 4 commits intognome-terminator:masterfrom Apr 12, 2021
TheBigS:add-new-vsplit-hsplit-cmd-dbus
Merged
Add new vsplit hsplit cmd dbus#390mattrose merged 4 commits intognome-terminator:masterfrom TheBigS:add-new-vsplit-hsplit-cmd-dbus
mattrose merged 4 commits intognome-terminator:masterfrom
TheBigS:add-new-vsplit-hsplit-cmd-dbus
Conversation
currently focused terminal
Member
|
Thanks so much for this! I'll try to take a look at this this weekend |
Member
|
Sorry for the long wait on this one. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes get_focused_terminal pull request too (which was separately functional) to add new
vsplit_cmdandhsplit_cmddbus ipc commands.Now we can get the focused_terminal and then split it and run a command all over dbus. Here is the python that could call the new
hsplit_cmdThen we see terminator now spawns and names the new horizontal split appropriately