fix issue with older vte lib#294
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Nov 18, 2020
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background overpainting stuff uses Vte.Terminal.get_color_background_for_draw() to get the background color, but this doesn't exist on versions prior to 0.60, if it doesn't exist, fallback to reading the background color from the config. I think It's a bit slower, but it works.
fixes #292