Fix: Key Binding Clearing in Preferences > Keybindings#224
Merged
mattrose merged 3 commits intognome-terminator:masterfrom Oct 14, 2020
Merged
Fix: Key Binding Clearing in Preferences > Keybindings#224mattrose merged 3 commits intognome-terminator:masterfrom
Preferences > Keybindings#224mattrose merged 3 commits intognome-terminator:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix incorrect clearing of key bindings in
Preferences > Keybindings, which was introduced in #196.Steps to Reproduce:
Preferences > Keybindings.Disabledand then press Backspace.This happens because
Gtk.accelerator_parse, which was used in #196, doesn't allowNoneto be used as a value. To fix this, the key binding value is now set to an empty string ("") instead ofNonethe moment it's been cleared.I also added a test to reproduce the behaviour described in this PR.