Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, as per usual, this has a bunch of caveats. It only works on Redhat-ish systems, as they're the ones who have integrated this patch. Cross-platform support for notification on prompt is bogged down in https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/13 so this is the best I can do until we can get VTE to agree on some kind of signal to the UI when a command is complete.
fixes #11 kinda