fix: convert enabled flag from string to boolean in custom commands#1062
Open
dmzoneill wants to merge 1 commit intognome-terminator:masterfrom
Open
Conversation
…ixes gnome-terminator#1047) the enabled config value is stored as a string but was being used directly as boolean, causing disabled commands to appear in menu. added string to boolean conversion to properly handle 'False' string.
Member
|
Is this something you consider fixed? Would you mind if I merged it? I don't have much time to work on Terminator these days, but I do like getting and merging contributions from users when I do have time? Re-opening. Please have patience. I do look at all PRs but don't have much time to properly inspect them. For the next few months I have some time set aside to look at Terminator PRs, so hopefully I'll get around to this one soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1047
the enabled config value is stored as a string but was being used directly as boolean, causing disabled commands to still appear in the right click menu. added proper string to boolean conversion to handle the 'False' string value correctly.