Closed
Conversation
* it's now an AXTabGroup - thanks to AXTabs the position of the tab and total tab count are announced * AXChildren shows only visible tabs, and all buttons (like overflow) * AXValue + AXValueChanged notification enable announcing new tab name when switching between them with Cmd-Shift-[] (for unknown reason does not do that quite yet)
* being AXRadioButton, VoiceOver indicates there is exclusive choice (i.e. only one button can be selected at a time, just like a radio button), also in conjunction with AXTabs of its parent reports proper position * implemented visual bounds - yields proper VoiceOver cursor bounds and also enables touch exploration * implemented AXTitle - so that the proper name is read when navigating the buttons * implemented AXValue - so that the selected tab can announce itself as such (AXFocused is for elements having keyboard focus, i.e. being first responder, which is something quite different than being selected from a list of other options)
This returned one more in case an overflow menu is shown.
Contributor
Author
|
For the record, just submitted as dorianj/PSMTabBarControl#32 |
Contributor
Author
|
For the record again, the pull request dorianj/PSMTabBarControl#32 has been pulled |
Owner
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More information in commit messages.
I will also try to submit a pull request to dorianj/PSMTabBarControl,
as I now discovered that is the source :-)