Use CodeType.replace() in copycode for Python > 3.8#136
Merged
moshez merged 1 commit intoglyph:masterfrom Apr 24, 2022
Merged
Conversation
moshez
approved these changes
Feb 20, 2022
Collaborator
moshez
left a comment
There was a problem hiding this comment.
I have marked this as "Approved", because I don't think aiming for a minimal diff should be a blocker. However, if it is possible, let's do that? I'll happily re-approve and merge if you amend the diff this way.
|
|
||
| if hasattr(code, "replace"): | ||
| return template.replace(**{"co_" + k : v for k, v in changes.items()}) | ||
| else: |
Collaborator
There was a problem hiding this comment.
Since the if statement returns, the else and the indent is redunant. Avoiding the extra indent makes it easier to verify that the diff does not change the old path. Would you mind doing that?
Owner
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #135