Hey @warappa could you take a look if skip the duplicate key is a valid solution. Thanks.

I think this is fine! 👍

The only question that arises is, if the deep-first-search is then the correct one to do or if in such a case a "top-first-search" would be better. You woukd have to test if the newer System.Text.Json is detected or the older one.

EDIT: But maybe this is not of an issue here, as we compare the AssemblyDefinitions against the previously resolved and passed down AssemblyDefinitions.

The only question that arises is, if the deep-first-search is then the correct one to do or if in such a case a "top-first-search" would be better. You woukd have to test if the newer System.Text.Json is detected or the older one.

EDIT: But maybe this is not of an issue here, as we compare the AssemblyDefinitions against the previously resolved and passed down AssemblyDefinitions.

Actually is not a System.Text.Json problem, is because I'm repacking the same file 2 times, or two files with the same assembly name.

Like creating a copy of the dll and repack the source and the copy.
ILRepack.exe /allowdup /allowduplicateresources /out:IssueILRepackOut.dll IssueILRepack.dll IssueILRepack.Copy.dll

This trigger the same key in the dictionary. #394