#387 Patch pack-uris in CLR strings#390
Conversation
… adapter for tests to be discovered and run
… if pack-uris are not patched in CLR strings
… handled by generic pack-uri patching
|
For reference: Test-run results screenshots of before and after this PR changes: Before (e8e56da) |
|
I'm worried about the overhead it adds for rewriting non-WPF assemblies. Every method is visited. Could we perhaps not add the XAML step if we don't have a reference to PresentationCore? This way if we're not a WPF app we don't pay the price. |
|
I will look into it. |
…entationFramework assembly
|
Thanks! Let me know when it's ready, I'll merge. |
|
I think for the issue at hand this should be it! Besides that I played around with the sources. Would there be interest for PRs regarding a general solution maintenance like central package management, tune .editorconfig (eg. use 2 spaces in csproj files), newer C# features, integration projects building if ILPack sources change (not the case now!) etc. And maybe some performance related stuff like Regex tuning, ordinal string comparison where possible etc.? |
|
Thanks! I'd like to keep the changes to the project to the absolute necessary minimum. I took over the maintenance to unify various forks, and changes will make maintenance difficult for other forks out there. Also I just don't have the time. |
|
Thank you for your explaination. I understand your sentiment and also your problem with limited time. |
|
You can certainly send PRs, and I appreciate the help. Just be mindful of maintainer burden. Things like reformatting every file would not be worth it. |


Add support for WPF applications/libraries which use pack-uris in their regular .NET
strings(aka. "outside of XAML").WPF-UI is an example of a library using this approach inside its
ThemesDictionaryandControlsDictionary.Main changes
IComponentConnectorpatching but reuses its string-patching functionalityGivenLibraryWithWpfPackUrisInClrStrings_MergedWpfApplicationRunsSuccessfullywhich runs newWPFPackUrisInClrStringsApplicationCoreapplicationMisc changes
Microsoft.NET.Test.SdkandNUnit3TestAdapterfor Visual Studio's Test Explorer to actually be able to execute the testsNote
The full test execution increased on my machine from 3.5 minutes to 4.5 minutes. I guess due to the thorough string inspections.
Pre-existing tests are still successful.