I do not know what are correct criteria to use, and it seems that not everyone has same understanding of what we should od (see #13303).

As I said in mentionned PR

I have no opinion about the way to filter things, but we recently had many PRs about this. We should probably add some tooltips next to some fields to clarify how it affects visibility. It could help both end-users and developers.

This PR only corrects the list of articles, so as not to display articles that are not accessible. I did not change the access check done when opening an article. So I don't think I'm questioning the current logic?

But I agree, that we could add tooltips in GLPI to clarify.

Same remark as for #13303:

FAQ items are public to everyone (within their entity) that has access to read FAQs. The additional visibility restrictions will have no affect in this case.

Only entity check should be added.

I don't share Adrien's point of view, because it would limit the targeting possibilities.

Well it's not my point of view; it's whats written in the documentation.

I also agree that the current behavior is dumb and that it should be changed to cover all possible criteria (and add a real draft / published dropdown reflecting the status, and a specific criteria to allow visibility to anonymous users) but probably not on a bugfix release.

@orthagh

To finalize this PR, we need to know how visibility rules are expected to be handled.

Well it's not my point of view; it's whats written in the documentation.
I also agree that the current behavior is dumb

There are not my words in the documentation.
I dislike also this behavior but we must keep the sync between code and doc.

So, if you want to change the behavior, and i agree with that, here is the list of things you must do:

• change the documentation
• target the main branch. We shouldn't be careless and push these kind of visibility changes to a bugfixes branch
• don't forget to add this in changelog

There is also a fix to be done in 10.0.7 if not done already, as discussed above the FAQ in the 10.0 version is missing the check on entities.

FAQ items are public to everyone (within their entity) that has access to read FAQs. The additional visibility restrictions will have no affect in this case.

There is also a fix to be done in 10.0.7 if not done already, as discussed above the FAQ in the 10.0 version is missing the check on entities.

FAQ items are public to everyone (within their entity) that has access to read FAQs. The additional visibility restrictions will have no affect in this case.

Indeed, it has been reported in #12566.

@Rom1-B Could you rebase this?