try: PHP compat test with phpcompatibility-dev#331
Merged
Conversation
a55dcb7 to
c6986c1
Compare
c6986c1 to
6b76ced
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
@Sidsector9 looks like the additional tests in |
Contributor
Author
|
@jeffpaul they do, but in case the plugin has more code changes which can violate the latest rules in PHP Compat-dev, then this action will flag them, but the already existing ones won't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
So we already have a PHP Compatibility action in place that tests for violations on PHP 8.0.
What this PR does is does the same but uses PHPCompatibility's dev branch . This is to ensure we are testing for violations with the latest changes. This is temporary until version 10.0.0 is released. Once released we can delete this and move these to the already existing PHP Compatibility action.
This action specifically runs on PHP 7.4 as recommended here.
Checklist:
Changelog Entry
Credits
Props @Sidsector9