Skip to content

Fix Fatal error on tracking a post with empty content#289

Merged
jeffpaul merged 3 commits intodevelopfrom
fix/288
May 21, 2022
Merged

Fix Fatal error on tracking a post with empty content#289
jeffpaul merged 3 commits intodevelopfrom
fix/288

Conversation

@cadic
Copy link
Copy Markdown
Contributor

@cadic cadic commented May 20, 2022

Description of the Change

Check post content not empty before parsing it with DOMDocument

Closes #288

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix - Fatal error on tracking a post with empty content

Credits

Props @cadic

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cadic cadic self-assigned this May 20, 2022
@cadic cadic added this to the 1.1.3 milestone May 20, 2022
@cadic cadic requested a review from jeffpaul May 20, 2022 15:05
@cadic cadic marked this pull request as ready for review May 20, 2022 15:05
@cadic cadic changed the title Fix/288 Fix Fatal error on tracking a post with empty content May 20, 2022
Copy link
Copy Markdown
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch and fix, thanks!

@jeffpaul jeffpaul merged commit a4e6207 into develop May 21, 2022
@jeffpaul jeffpaul deleted the fix/288 branch May 21, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error when saving post with empty content

2 participants