Fix national checksum calculation for Belgium#119
Merged
globalcitizen merged 1 commit intoglobalcitizen:masterfrom Aug 10, 2022
Merged
Fix national checksum calculation for Belgium#119globalcitizen merged 1 commit intoglobalcitizen:masterfrom
globalcitizen merged 1 commit intoglobalcitizen:masterfrom
Conversation
The function never validated the checksum correctly.
Owner
|
Great catch! What a horrible bug. Thanks for a well documented pull request. The tests currently only verify that a set of example pass, they cannot catch logic errors where the verification code always returns true. I will run a round of further tests on the suite of examples just to verify they all work and modifications fail, then push this out. |
Owner
|
Released as v4.1.1. Thanks again! In case you are interested, we could probably do with:
|
Contributor
Author
|
Ok, I'll give it a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function never validated the national checksum for Belgium correctly. What it did was:
I changed it so that it now calculates it following the correct rules.
Here is a script with the current and new code
https://onlinephp.io/c/60fa7