Configurable HorizontalPodAutoscaler: business logic change#2
Open
gliush wants to merge 15 commits intoconfigurable-hpa-limitsfrom
Open
Configurable HorizontalPodAutoscaler: business logic change#2gliush wants to merge 15 commits intoconfigurable-hpa-limitsfrom
gliush wants to merge 15 commits intoconfigurable-hpa-limitsfrom
Conversation
2af47cc to
7f3f689
Compare
a362978 to
d2bb60a
Compare
arjunrn
reviewed
Oct 18, 2019
Collaborator
There was a problem hiding this comment.
This function should also be renamed in that case to calculateScaleUpLimitBehavior
Owner
Author
There was a problem hiding this comment.
Renamed it to calculateScaleUpLimitWithScalingRules
arjunrn
reviewed
Oct 18, 2019
Collaborator
There was a problem hiding this comment.
We should generate the fully populated behavior object only one and use it in normalizeDesiredReplicas and in storeScaleEvent.
arjunrn
reviewed
Oct 18, 2019
Collaborator
There was a problem hiding this comment.
Why do we want to store scale events for HPAs which don't have behavior. I would argue that we should simply wrap this function call in the behavior!=nil condition as well.
arjunrn
reviewed
Oct 18, 2019
Collaborator
There was a problem hiding this comment.
assert.Equal takes a list of arguments so the fmt.Sprintf is not required.
Owner
Author
52dad0d to
dde049b
Compare
877d2ff to
76342ba
Compare
- Uses capital letters for const - Uses JSON names for fields - Specified default values
13f7ddc to
c32de0c
Compare
dde049b to
fc130c7
Compare
Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
- ScaleEvents are now marked as "outdated" and stored in one place - That fixed two different problems related to how the controller handles store events - Add tests to cover possible problems
fc130c7 to
e05ef55
Compare
288e5de to
b6b34cb
Compare
72a1076 to
14bb2cd
Compare
3ababc8 to
8b159e8
Compare
8b159e8 to
bad0417
Compare
bad0417 to
8ab2262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduce an algorithm-agnostic HPA object configuration that will configure each particular HPA scaling behavior.
This is the second PR with all the business logic changes.
The first PR with API changes and full explanation: kubernetes#74525
KEP PR: kubernetes/enhancements#883
KEP PR: kubernetes/enhancements#1234
What type of PR is this?
/kind feature