fix: change --update flag to --update-cache in docs and tests#503
fix: change --update flag to --update-cache in docs and tests#503josegonzalez merged 3 commits intogliderlabs:masterfrom
--update flag to --update-cache in docs and tests#503Conversation
|
@josegonzalez Friendly ping. :) If possible it would be nice if you could leave a comment. I stumbled upon this issue as well, wondering what the |
|
If this gets rebased and tests pass, I can merge. |
|
@josegonzalez okay, i'll fix it. |
|
Make sure to comment here again when you do - Github won't send notifications on updated PRs and I have a ton of repos that make PR watching kinda not possible :( |
|
@josegonzalez Fixed. |
| FROM gliderlabs/alpine:3.3 | ||
|
|
||
| RUN apk add --update \ | ||
| RUN apk add --update-cache \ |
There was a problem hiding this comment.
Perhaps instead use the --no-cache option, which installs the package without creating a local cache; with that, it's also not needed to rm -rf /var/cache/apk/* afterwards
RUN apk add --no-cache \
python \
python-dev \
py-pip \
build-base \
&& pip install virtualenvThere was a problem hiding this comment.
it's also not needed to rm -rf /var/cache/apk/* afterwards
I think so.
However this PR does not responsible for it, IMO.
There was a problem hiding this comment.
Do either of you mind going in and making a PR with the above change?
There was a problem hiding this comment.
@josegonzalez Sorry, I have no motivation.
There was a problem hiding this comment.
No worries, its all OSS so if folks have time to fix, thats great, if not, thats cool too :)
apk --updateflag is really--update-cache.https://github.com/alpinelinux/apk-tools/blob/v2.10.3/src/apk.c#L201
Apk uses
getopt_long (3),https://github.com/alpinelinux/apk-tools/blob/v2.10.3/src/apk.c#L574
So,
--updateflag is only abbreviated from--update-cacheby getopt_long.https://linux.die.net/man/3/getopt_long